Corresponding timeline option for directory input
#145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
fukusuket
reviewed
Mar 23, 2024
There was a problem hiding this comment.
@hitenkoku
When I tried specifying a directory in -t option, file does not exist was displayed, but maybe I'm using it incorrectly?🤔 (I think that changed it so that the directory can be specified in the -t option instead of the -d option.)
% pwd
/Users/fukusuke/Hayabusa/hayabusa-2.13.0-mac
fukusuke@fukusukenoMacBook-Air hayabusa-2.13.0-mac % ls -la tl
total 688144
drwxr-xr-x 10 fukusuke staff 320 3 22 20:19 .
drwx------@ 24 fukusuke staff 768 3 23 22:30 ..
-rw-r--r-- 1 fukusuke staff 44025018 3 17 09:49 timeline--European-time.jsonl
-rw-r--r-- 1 fukusuke staff 43927488 3 17 09:50 timeline--ISO-8601.jsonl
-rw-r--r-- 1 fukusuke staff 44072814 3 17 09:50 timeline--RFC-2822.jsonl
-rw-r--r-- 1 fukusuke staff 44089744 3 17 09:50 timeline--RFC-3339.jsonl
-rw-r--r-- 1 fukusuke staff 44025018 3 17 09:51 timeline--US-military-time.jsonl
-rw-r--r-- 1 fukusuke staff 44122107 3 17 09:51 timeline--US-time.jsonl
-rw-r--r-- 1 fukusuke staff 44025018 3 17 09:51 timeline--UTC.jsonl
-rw-r--r-- 1 fukusuke staff 44025018 3 17 13:50 timeline.jsonl
fukusuke@fukusukenoMacBook-Air hayabusa-2.13.0-mac % ./takajo automagic -q -t /Users/fukusuke/Hayabusa/hayabusa-2.13.0-mac/tl
The file '/Users/fukusuke/Hayabusa/hayabusa-2.13.0-mac/tl' does not exist. Please specify a valid file path.
fukusuke@fukusukenoMacBook-Air hayabusa-2.13.0-mac % ./takajo automagic -q -t /Users/fukusuke/Hayabusa/hayabusa-2.13.0-mac/tl/
The file '/Users/fukusuke/Hayabusa/hayabusa-2.13.0-mac/tl/' does not exist. Please specify a valid file path.
fukusuke@fukusukenoMacBook-Air hayabusa-2.13.0-mac % ./takajo automagic -q -t ./tl
The file './tl' does not exist. Please specify a valid file path.
Also, csv-timeline seems to fail in Integration-Test, so could you please check it?🙏
https:/Yamato-Security/takajo/actions/runs/8402036417/job/23011009274#step:24:26
|
@hitenkoku
Therefore, I think it would be nice if we could specify the root path to
|
|
Sorry to bother you again...😅 
|
|
@fukusuket Sorry for late reply.
|
|
@hitenkoku Also, could you please check the following error?🙏 |
|
I also checked in my Windows 11 environment! but it seems to be an error🤔 |
|
My confirmation was insufficient. I fixed in 1c02961. Would you check it? |
|
@hitenkoku It seems that only the last JSONL analysis result remains in the CSV file.(because it is overwritten each time JSONL analysis is performed). I think we could solve the file overwriting issue if we control the directory for loop on the takajoCore.nim side🤔 takajo/src/takajopkg/takajoCore.nim Line 45 in 1c02961 |
I would appreciate it if you could check the above error as well🙏 |
|
Thanks for your review. |
|
I fixed following problem. Evidence is https:/Yamato-Security/takajo/actions/runs/8471381947. Would you check it?
|
|
@fukusuket I fixed #145 (comment) problem in b816f9c. Excuse me for repeatedly asking for a review, but could you please check? |
|
I get the following error: |
|
@hitenkoku @YamatoSecurity |
I found the problem: |
YamatoSecurity
approved these changes
Mar 29, 2024
fukusuket
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
-d, --directory#133timelineoption for directory input